Issue610duplicatesagain

Merged
#193 · Created  · Last updated

Merged pull request

Merged in issue610duplicatesagain (pull request #193)

9162ebc·Author: ·Closed by: ·2018-05-15

Description

  • New table in models to hold UID of each object that matches existing study to aid duplicates checking in QR. WIP [skip ci]

  • Now appears to function for RDSR. Need to modify the tests, but works with current tests locally. WIP, refs #610. Need also to look at other import objects. [skip ci]

  • Corrected generation of object UID list. Now writes previous UID list to new study after deleting old. Added test for UID list to cumulative RDSR test, plus test for duplicate log. Update required for testfixtures. [skip ci] because tested locally and saving minutes, 24 remaining till the 10th...

  • Added sop instance UID tests for continued studies. Instance UID now added just to applicable study in db. Now to look at other imports. [skip ci] because tested locally. Refs #610

  • Added checking of SOP instance UID to DX _create_event. Also changed logic for multiple studies with the same UID - previous code would have fallen over. Need to add UID stuff to new DX study function. [skip ci] because tested locally. Refs #610

  • Now adds SOP UID to database for new studies too. [skip ci] because tested locally. Refs #610

  • Added a couple of debug messages; added check that duplicate image import reulsts in debug message, and check uid list is created correctly. [skip ci] because tested locally. Refs #610

  • Fixed image import when more than one existing study in the database matches the new image study UID. Refs #628. Added tests that helped to fix the function.

  • Correcting the tests that refer to pk as when the whole test suite is run the database is constantly being populated and emptied. Doesn't fix pipelines error though. Test pass fine on laptop...

  • Deliberately setting log check to fail to see if it gives me a clue as to what is happening with pipelines. Modified tox to see what versions we are running.

  • Changing logging level in sample local_settings to see if that enables logs to be seen...

  • Reverted sample local_settings. Added explicit setting of log level for each log capture. Refs #610, #628

  • Adding a sed regex to replace all Info levels with Debug in local settings. Sledgehammer... Refs #610, #628 Also removed pip list.

  • Adding the mod to set the logging level to debug for all the testing. Refs #610, #628

  • Refactored _create_event into separate module so I don't have to re-code it for mammo. Works for DX, haven't started modifying for mammo yet. Refs #610, #628

  • Substituted each logging message 'DX' with modality. Added requirement to check object is not the secondary capture Hologic object.. Refs #610, #628

  • Rename image_import_create_event to get_study_check_dup. Removed _create_event from each module. Set mam to use the new function. Refs #610, #628

  • Adding test files to enable testing of mammo import with duplicates etc. Started on tests. Refs #610, #628

  • Removed try except and corrected an error it was hiding. Initial test works. Refs #610, #628

  • Explicitly named mam log for consistency. Added record_sop for new studies. Added tests for importing new event and duplicate vent a second time. Lots of duplication still... for another time! Refs #610, #628

  • Replaced check duplicates QR code - was based on series instance UID and series time, now based on SOPInstanceUID. Modified tests to provide the new information, and split them up. Refs #610

 

0 attachments

0 comments

Loading commits...