Commits

Author Commit Message Labels Comments Date
jcarreira
Fixing a problem with checking the before state of the value stack in the ActionTag
savaki
- removed Velocity's dependency on Renderer and IterationRenderer through the code ... yay! Now, all velocity templates utilize a PageContext and render to the PageContext's JspWriter. The perk from this approach is that any existing JSP tag library should be usable by velocity without modification.
jcarreira
Updating Xwork jar
jcarreira
All tests working for me... lots of little tweaks as I was digging through the codebase...
plightbo
latest xwork -- nulls are treated nicer now and with ognl 2.6.4 we'll be prepared
plightbo
only 3 tests failing now.
plightbo
fixed more tests. did i mention how much i hate statics. so f'ing fragile!
plightbo
THREAD LOCALS ARE EVIL, STOP USING THEM ALL OVER THE PLACE :) Seriously though, static blocks, thread locals, and static fields are just nasty to deal with. Always try to run all the tests in a single suite so you can get a feel for how nasty it all is. And this isn't just good for testing quicker, it's important because testing code that uses ThreadLocals only at the start of a thread isn't a good test being that in a servlet container only 1 out of all the requests will be like that test emulates.
plightbo
some tests pass, but more to go
plightbo
all the examples work except for anything that uses velocity
plightbo
delete
plightbo
looks like a line break issue?
plightbo
country test works
plightbo
even better way to handle this third column
plightbo
tags page renders everything and does benchmarks much nicer now
plightbo
fixed some of this stuff, yo
plightbo
more cleanup, the examples don't fully work yet
plightbo
can we PLEASE make sure the tests all run together in a single suite. this is getting annoying having to clean it up after every change
jcarreira
Finishing up TextTag and testing and refactored the Tag tests a bit
jcarreira
Updating Xwork jar file and small change to TextTag
plightbo
forgot my added files, and hopefully idea will delete the files too!
plightbo
whoa, the biggest commit EVER! But don't worry, I did all this while on the train so I didn't have enough time to really break much :) Actually, what this is is a massive refactoring to make sure all the JSP tags work in SiteMesh filters (translation: they try to get the VS from the request). I also cleaned up (simplified) a bunch of the tests
plightbo
submit tests and some more cleanup
plightbo
hidden test
plightbo
file and component test
plightbo
all tests pass, but there are some missing tests. time to create them
jcarreira
Adding TextTag... refactoring ParameterizedTag's...
plightbo
select tag passes the tests
plightbo
whoops, better add this for the test
plightbo
token tag passes, w00t w00t
  1. Prev
  2. Next