Anonymous avatar Anonymous committed 9b7bcc2

Solved bug XW-702 - removed call to System.out and added exception loging instead

git-svn-id: http://svn.opensymphony.com/svn/xwork/trunk@1993 e221344d-f017-0410-9bd5-d282ab1896d7

Comments (0)

Files changed (1)

core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java

             context.put(REPORT_ERRORS_ON_NO_PROP, (throwExceptionOnFailure) ? Boolean.TRUE : Boolean.FALSE);
             ognlUtil.setValue(expr, context, root, value);
         } catch (OgnlException e) {
+            String msg = "Error setting expression '" + expr + "' with value '" + value + "'";
+            if (LOG.isWarnEnabled()) {
+                LOG.warn(msg, e);
+            }
             if (throwExceptionOnFailure) {
-                e.printStackTrace(System.out);
-                System.out.println("expr: " + expr + " val: " + value + " context: " + context + " root:" + root + " value: " + value);
-                String msg = "Error setting expression '" + expr + "' with value '" + value + "'";
                 throw new XWorkException(msg, e);
-            } else {
-                if (LOG.isWarnEnabled()) {
-                    LOG.warn("Error setting value", e);
-                }
             }
         } catch (RuntimeException re) { //XW-281
             if (throwExceptionOnFailure) {
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.