Anonymous avatar Anonymous committed dfaa5c0

XW-705 ParametersInterceptor is not filtering acceptParams properly

git-svn-id: http://svn.opensymphony.com/svn/xwork/trunk@2004 e221344d-f017-0410-9bd5-d282ab1896d7

Comments (0)

Files changed (2)

core/src/main/java/com/opensymphony/xwork2/interceptor/ParametersInterceptor.java

             return true;
         }
         return false;
-    }
+    }    
 
     protected boolean isAccepted(String paramName) {
         if (!this.acceptParams.isEmpty()) {
                     return true;
                 }
             }
-        }
-        return acceptedPattern.matcher(paramName).matches();
+            return false;
+        } else
+            return acceptedPattern.matcher(paramName).matches();
     }
 
     protected boolean isExcluded(String paramName) {

core/src/test/java/com/opensymphony/xwork2/interceptor/ParametersInterceptorTest.java

         Map<String, Object> params = new HashMap<String, Object>() {
             {
                 put("blah", "This is blah");
-                put("['baz']", "123");
+                put("baz", "123");
                 put("name", "try_1");
                 put("(name)", "try_2");
                 put("['name']", "try_3");
         SimpleAction action = (SimpleAction) proxy.getAction();
         assertNull(action.getName());
         assertEquals("This is blah", (action).getBlah());
-         assertEquals(123, action.getBaz());
+        assertEquals(123, action.getBaz());
     }
 
 
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.