Unmount not cleaning up staging area

[Ali Mashtizadeh]

Unmounting an ori file system sometimes does not delete the staging area journal after all changes have been committed. On the next mount the orifs tool will warn users that the file system may have been unmounted uncleanly even though this is not the case.

[LightPulserTeam]

The much more severe bug is that all files which are not committed are lost ( names and location is lost, content remains in /tmp/fuse with random names) in case orifs terminates unexpectedly. This files also would prevent orifs to start next time.

In order to start using ori for real world projects all staged files must be recovered on start up.

Please consider and discuss following approach:

1. Change the path for staging from ~/.ori/MyRepo.ori/tmp/fuse to something like ~/.ori/MyRepo.ori/staging
2. Store all uncommitted files with their real names and paths there. (E.g a file MyRepo/foo in repository would be in ~/.ori/MyRepo.ori/staging/foo
3. On startup, integrate them again into internal structures. (usign kind of internal graft command?)

PS: ori is great project anyway. :-)

Alex

[Ali Mashtizadeh]

We're getting rid of the staging area very soon. Instead we will snapshot more frequently into a special branch. There's a lot of unwanted side effects including performance and complexity issues with the current design.

[Ali Mashtizadeh]

For folks who do hit this the filenames are available in the journal file. That said this issue is going away soon.