Pull requests

#2 Declined
Repository
5lava 5lava
Branch
master
Repository
osmanov osmanov
Branch
master

Extra warning is removed, added EvLoop::destroy() method.

Author
  1. 5lava avatar5lava
Reviewers
Description

Fix: Warning "Returning previously created default loop" makes no sense in EvLoop::defaultLoop(). Add: EvLoop::destroy() method. It is NOT yet supposed to be used with default loop.

EvLoop::destroy() works fine with any loops but default. It must be fixed to update MyG(default_loop) when calling on default loop, otherwise php_ev_loop_object_ctor() will return a reference to a destroyed loop. Sorry, I'm not a Zend guru.

Comments (0)

Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.