Extra warning is removed, added EvLoop::destroy() method.
Slava
Branch: Deleted repository:master
Branch: osmanov/pecl-ev:master
Declined
Declined pull request
I've removed the warning. Let's leave `zval` copying there pro tem. I wouldn't add `EvLoop::destroy` method since the loop object is destroyed/free'd automatically when it goes out of scope.
Closed by: Ruslan Osmanov·2013-07-20
Fix: Warning "Returning previously created default loop" makes no sense in EvLoop::defaultLoop(). Add: EvLoop::destroy() method. It is NOT yet supposed to be used with default loop.
EvLoop::destroy() works fine with any loops but default. It must be fixed to update MyG(default_loop) when calling on default loop, otherwise php_ev_loop_object_ctor() will return a reference to a destroyed loop. Sorry, I'm not a Zend guru.