1. Ruslan Osmanov
  2. pecl-ev

Pull requests

#2 Declined
Repository
Deleted repository
Branch
master (bbf7b0452592)
Repository
pecl-ev
Branch
master

Extra warning is removed, added EvLoop::destroy() method.

Author
  1. 5lava
Reviewers
Description

Fix: Warning "Returning previously created default loop" makes no sense in EvLoop::defaultLoop(). Add: EvLoop::destroy() method. It is NOT yet supposed to be used with default loop.

EvLoop::destroy() works fine with any loops but default. It must be fixed to update MyG(default_loop) when calling on default loop, otherwise php_ev_loop_object_ctor() will return a reference to a destroyed loop. Sorry, I'm not a Zend guru.

  • Learn about pull requests

Comments (0)