Pull requests

#5 Merged

Windows compatibility

  1. Anatol Belski

Basic windows support done, 10 of the 12 tests pass for me. Both TS/NTS are fine. Still there might be something to do

  • the openssl support isn't provided by the current libevent distribution, so disabled in the ext
  • test failing ext\event\tests\02-features.phpt because of not supported features, not sure yet it's windows specific or some libevent build defect again
  • test ext\event\tests\11-gc-cycles.phpt still crashes on 5.4.5 where I've developed with the following BT

    ntdll.dll!RtlpWaitOnCriticalSection() Unknown ntdll.dll!RtlpEnterCriticalSectionContended() Unknown ntdll.dll!_RtlEnterCriticalSection@4() Unknown

    php_event.dll!__event_debugx() C php5ts.dll!zend_do_fcall_common_helper_SPEC(_zend_execute_data * execute_data, void * * tsrm_ls) Line 642 C php5ts.dll!ZEND_DO_FCALL_BY_NAME_SPEC_HANDLER(_zend_execute_data * execute_data, void * * tsrm_ls) Line 753 C php5ts.dll!execute(_zend_op_array * op_array, void * * tsrm_ls) Line 410 C php5ts.dll!zend_execute_scripts(int type, void * * tsrm_ls, _zval_struct * retval, int file_count, ...) Line 1280 C php5ts.dll!php_execute_script(_zend_file_handle * primary_file, void * * tsrm_ls) Line 2473 C php.exe!do_cli(int argc, char * argv, void * * tsrm_ls) Line 989 C php.exe!main(int argc, char * * argv) Line 1366 C

Of that all issues only the crashing one is bad. As i can see it's something with calling the callback from userspace, didn't dig deeper yet.



  • Learn about pull requests

Comments (3)

  1. Ruslan Osmanov repo owner

    Thanks for your work!

    The second test fails because O1 feature is not supported on Windows:

    It is easy to set up an event_config that requires a backend that your OS does not provide. For example, as of Libevent 2.0.1-alpha, there is no O(1) backend for Windows, and no backend on Linux that provides both EV_FEATURE_FDS and EV_FEATURE_O1

    (http://www.wangafu.net/~nickm/libevent-book/Ref2_eventbase.html). Have to add some OS checks there.

    Unfortunately, can't help with the crash(I didn't work on Windows for 5 years :-/) I'd prepare for new release, but the crash... Would you return to this issue after a while?

    Thanks again for your contribution.

  2. Anatol Belski author

    Thanks for merging. I don't mind if you add me to the maintainers, will turn back to the issues in some time. Currently doing the third tour through PECL exts for win compat. Cool stuff like event or eio is sometimes quite tricky even on linux, so doing suchlike exts now, as the simpler are almost done. Anyway feel free to ping me for libevent dep update or any other related stuff, I'll find the time for that.