Deprecate gazebo::common::Color in favor of ignition::math::Color

Issue #2390 resolved
Louise Poubel created an issue

This was started on pull request #2786 and continued on pull request #2818.

Remaining public API:

GUI

  • gazebo::gui::ConfigWidget
    • SetColorWidgetValue
    • ColorWidgetValue
    • ColorValueChanged

Rendering

  • gazebo::rendering::Camera
    • SetBackgroundColor
  • gazebo::rendering::DynamicLines
    • AddPoint
    • AddPoint
    • SetColor
  • gazebo::rendering::Grid
    • Grid
    • SetColor
    • Color
  • gazebo::rendering::LaserVisual
    • SetEmissive
  • gazebo::rendering::Light
    • SetDiffuseColor
    • DiffuseColor
    • SetSpecularColor
    • SpecularColor
  • gazebo::rendering::MovableText
    • Load
    • SetColor
    • GetColor
  • gazebo::rendering::Scene
    • SetAmbientColor
    • AmbientColor
    • SetBackgroundColor
    • BackgroundColor
    • CreateGrid
    • SetFog
  • gazebo::rendering::WideAngleCamera
    • SetBackgroundColor

Comments (11)

  1. Steven Peters

    Actually that one's trivial because the Color objects are optional parameters and I think nothing is using it

  2. Louise Poubel reporter

    I didn't list them because I thought the test functions weren't being installed. But in any case, we will need to remove all instances. But we could always leave fixing non-breaking changes for after the release (i.e. fix warnings).

  3. Louise Poubel reporter

    I just realized I failed to find some uses of Color in gazebo::common because I had searched for common::Color. These should also be deprecated:

    • gazebo::common::Image

      • GetPixel
      • GetAvgColor
      • GetMaxColor
    • gazebo::common::Material

      • Material
      • SetAmbient
      • GetAmbient
      • SetDiffuse
      • GetDiffuse
      • SetSpecular
      • GetSpecular
      • SetEmissive
      • GetEmissive
  4. MarcZofka

    I just recognized that in the GZ9 source code, common::Color is deprecated, so i might suggest to close this issue.

  5. Log in to comment