Pull requests

#236 Merged
Repository
Branch
Fix cmake
Repository
Branch
gazebo_1.4

Add QUIET to find_package() to avoid warnings when ROS not installed.

Author
  1. Nathan Koenig
Reviewers
Description
No description
  • Learn about pull requests

Comments (6)

    1. gerkey

      Interesting point. That wasn't previously the case when we relied on the manual setting of PKG_CONFIG_PATH.

      Please do update the Jenkins scripts, as well other places where that's used or mentioned, which should include:

      • gazebo-release/ubuntu/debian/rules: currently set PKG_CONFIG_PATH in the configure step; I guess that that should be replaced by sourcing ROS's setup.sh, similar to how we do it drcsim-release
      • http://gazebosim.org/wiki/DRC/Install#Ubuntu_Linux_2 : installation instructions prescribe setting PKG_CONFIG_PATH on the cmake call; should instead source ROS's setup.sh
      1. John Hsu

        is there a reason to source /opt/ros/[ros distro]/setup.sh rather than just setting CMAKE_PREFIX_PATH=/opt/ros/[ros istro]/share? It seems sourcing ROS setup.sh might have additional environment variable setting that we don't need.