1. OpenSourceRoboticsFoundation
  2. Simulation
  3. gazebo

Pull requests

#179 Merged
Repository
Branch
master_world_valgrind
Repository
Branch
default

Pair of bugs found by valgrind

Author
  1. Steven Peters
Reviewers
Description

There was a race condition in the bullet regression test when compiled in Debug mode. With help from Brian and valgrind, we identified two bugs:

  1. The private bool gazebo::World::stop was not initialized in the constructor, which led to the race condition that we saw, in which the physics engine wasn't always starting.

  2. valgrind identified an increment of an uninitialized pointer in gazebo::Master::RunOnce. The variable iter was cleared at the end of this->RemoveConnection, and then was being incremented right after that function call.

  • Learn about pull requests

Comments (4)