modified actor to overcome the distortion when loaded with BVH animation

#2957 Open
Repository
mingfeisun
Branch
default
Repository
osrf
Branch
default

Bitbucket cannot automatically merge this request.

The commits that make up this pull request have been removed.

Bitbucket cannot automatically merge this request due to conflicts.

Review the conflicts on the Overview tab. You can then either decline the request or merge it manually on your local system using the following commands:

hg update default
hg pull -r default https://bitbucket.org/mingfeisun/gazebo
hg merge b0a41460431e
hg commit -m 'Merged in mingfeisun/gazebo (pull request #2957)'
Author
  1. mingfei sun
Reviewers
Description

In Actor.cc and Actor.hh, add bone length alignment and initial body pose adjustment between dae skin skeleton and BVH animation skeleton.

Comments (3)

  1. Louise Poubel

    Than you for the pull request! This addresses issue #2447

    I made a pull request to your repository fixing the style and adding an example world.

    The changes work great for the few BVH files from the CMU database that I tried! This will allow much more interesting animations in Gazebo now 😄

    traffic3.gif

    I did notice one problem though. When I run worlds/actor.world, the actor is walking inside the ground. When I run worlds/cafe.world though, the actors look ok. The main difference between these worlds is that the former uses an SDF script tag while the latter uses a plugin. I suspect this pull request may be fixing a problem with the script, which is being compensated for on the world, so we may need to change the world. I haven't looked closely at the code yet though.

  2. Steven Peters

    this is an important pull request, but we aren't ready to merge it before code freeze for gazebo10, and since this changes ABI by adding new private/protected member variables to the Actor class, I've added a private data pointer to the Actor class in pull request #3067 so that this functionality could be included in gazebo 10.1 once we have a chance to review it

    we can advise on the proper way to use the private data pointer if you have any questions