Pull requests

#4 Merged
Repository
Branch
john
Repository
Branch
dev

merging into dev and a few fixes

Author
  1. John Hsu
Reviewers
Description

changes to Nate's comments added.

Mainly a big merge into dev. This patch also contains: - Fixes so bullet compiles. - Fix a start up deadlock race condition in ConnectionManager. - Fix some places where switching to Scoped joint names not complete. - Major refactor of JointController::SetJointPosition. It's now much cleaner. - Added set_joint.cc and set_pose_loop.cc for testing purposes. Hard to break up the merge into smaller patches because most of the changes came from different merges upstream.

  • Learn about pull requests

Comments (3)

  1. Nathan Koenig

    CMakeLists.txt

    37: spelling mistake "ot"

    gazebo/physics/Link.cc

    403: Rename function to ::GetChildJointsLinks()

    416: Rename function to ::GetParentJointsLinks()

    gazebo/physics/Link.hh

    289:

    /// \brief Returns a vector of links that are connected to this link via child joints.
    /// \return A vector of Link, where each Link is connected to this via a child joint.
    

    Make GetParentLinks function match in style and content.

    These functions should also use the Link_V typedef.

    gazebo/physics/Model.cc

    554: A child of a model is not guaranteed to be a link. Need to use:

        if (this->GetChild(j)->HasType(Base::LINK))
    

    test/regression/set_joint.cc

    There are no test hooks.

    test/regression/set_pose.cc

    There are no test hooks.

    test/regression/set_pose_loop.cc

    There are no test hooks.

    1. John Hsu author

      Thanks for the updates, w.r.t.

      test/regression/set_joint.cc test/regression/set_pose.cc test/regression/set_pose_loop.cc

      first pass is that these things don't segfault. will add test hooks.