#535 Merged at 9cc6308
Repository
osrf
Branch
default
Author
  1. Yeshasvi Tirupachuri
Reviewers
Description

Following the discussion in https://github.com/ros-simulation/gazebo_ros_pkgs/issues/512#issuecomment-478360642, this PR updates the installation notes of ros2 and gazebo_ros_pkgs.

Comments (10)

  1. Jose Luis Rivero

    Thanks for the contribution Yeshasvi.

    If I’m not wrong we are including in the changes the instructions to install ros2 from source. While this can be useful for some use cases I think that it brings some inconvenient side effects: it’s going to be harder to maintain since the ros2 install instructions can change at any time, the main use case (install gazebo_ros_pkgs from binaries or source) does not directly benefit from the ros2 installation text, changes increases the size of the tutorial more than 40%.

    1. Louise Poubel

      Agreed, this tutorial can link to the official ROS 2 install instructions for the core and focus on gazebo_ros_pkgs

    2. Yeshasvi Tirupachuri author

      The main intention for additional documentation is to point out which branch of ros2 is compatible with the active branches of gazebo_ros_pkgs. I noticed that this information was missing and the current documentation was not clear on indicating the compatible branches correctly. But I agree that the ros2 installation need not be in this tutorial explicitly.

      1. Jose Luis Rivero

        My fault for not being clear in my first message: your intention and the changes you made in this PR with respect to it I think it is pretty useful and very welcome. My comment just apply to those sentences and commands which are duplicated from the ROS2 installation doc. We can remove them and keep going with the rest of this PR.

        1. Yeshasvi Tirupachuri author

          Updated the tutorial by removing ros2 installation details but added information related to the current stable and active branches. Also, updated the code format, numbering and line length. @chapulina

    1. Louise Poubel

      Sorry for the delay, I did another pass. It's mostly small details now, almost there!

        1. Louise Poubel

          Thanks for iterating! I merged and did some final tweaks to remove unnecessary changes and use wget to get the supplemental repos.