#10 Merged at 417b256
Repository
mohamd_ayman
Branch
entity_delete
Repository
osrf
Branch
default

Entity_delete

Author
  1. Mohamd Ayman
Reviewers
Description
  • added delete entity feature

  • added the test for deletion

Comments (8)

  1. Mohamd Ayman author

    I think this PR is ok, so we can merge it on your mark. Hugo Boyer I needed this feature to test the entity_delete topic, plus I thought we might need it later, deletion is an important functionality after all.

  2. Hugo Boyer

    Can you please add a "deleteEntity" on the Gazebo object in index.js. This will allow to call gazebo.deleteEntity instead of gazebo.sim.deleteEntity. Please also add documentation for the call, because we will generate jsdoc type (markdown) documentation for gazebojs in the repo (soon).

    1. Mohamd Ayman author

      can we create a msg of a certain type in index.js?, i'm trying to publish a request msgs for the deletion, the parameter of the msg is what i' kinda stuck at, from msgs.cc i can figure out the parameters, but i still can't guess how the msg json should really look like

       msgs::Request *CreateRequest(const std::string &_request,
              const std::string &_data)
          {
            msgs::Request *request = new msgs::Request;
      
            request->set_request(_request);
            request->set_data(_data);
            request->set_id(ignition::math::Rand::IntUniform(1, 10000));
      
            return request;
          }