patches for customclientraw

Issue #30 resolved
John Harvey created an issue

Couple of patches attached the 1st for the customclientraw.txt fixes 3 fields which are filled in with the wrong value. The bearingTM seems odd but sems to match how the steelgauges code interprets it (I think). The second patch is for the python where a couple of variables arent initailed if an exception is thrown. (I still need to work out why i'm getting the exception).

Final point is that the documentation talks about schemas.py which doesnt exits in the source or any download. Maybe just better to say how to modify schemas.py?

Thanks

John

Comments (4)

  1. Gary Roderick

    customclientraw patch applied to development branch. Once current development branch is rolled into the master wdtags.py will no longer be in use. New weewx-WD search list extension code will pick up on the issue addressed in the proposed wdtags.py patch.

  2. Gary Roderick

    Just reviewing customclientraw before pushing latest revision to development and I notice that "windTM" uses the WD tag %maxavgspd% which I believe is the max average wind speed for the day. This is in disagreement with the patch that proposes the Weewx tag $day.wind.maxtime. Customclientraw time fields typically start with 'T' which makes me believe the field requires a number not a time. Using the Weewx-WD tag $day.windAv.max unless I am convinced otherwise.

  3. John Harvey reporter

    Yes your right, Sorry about that. It use that for the maxAvgToday so not quite what was there either but better than a ime.

  4. Log in to comment