Re-fetch page for which title is missing

Issue #12 open
零欸特 created an issue

Adding a link to pocket results in a "null" title

Steps to reproduce:

  1. Right-click on a link
  2. Click "Add to pocket"

https://i.imgur.com/oHO67Km.png

Comments (7)

  1. Pierre-Adrien Buisson repo owner

    Hi ! Thanks for the report. I can't reproduce this issue, everything works fine on my side for right-click "add to pocket", the title is correctly set.

    • Can you reproduce the bug on any page / link?
    • Which version of Firefox and In My Pocket are you using?
  2. 零欸特 reporter

    Interesting, not every link produces a "null" title.
    https://i.imgur.com/wJr7f4U.png

    • Firefox Dev 59.0b11
    • In My Pocket 0.8.1
  3. Pierre-Adrien Buisson repo owner
    • changed status to open

    Oh indeed, I have problems with links from "Greasy forum" too. Still, for some of your examples (bitbucket.org/eight04/ for instance), I'm not getting a null title.

    Capture d’écran 2018-02-22 à 09.57.00.png

    Anyway I'll look into it, based on greasy forums links at least, and fix this.

  4. Pierre-Adrien Buisson repo owner

    Well, I don't have an obvious explanation yet. I might have a solution but no easy fix (if no title, I could fetch the page and parse it to get the title part) : the link is not yet opened so I don't have it's title available, and the pocket api returns a null title.

    I'm currently checking with Pocket API team if there might be a fix on their side, and otherwise I'll look into solutions for this issue.

  5. Pierre-Adrien Buisson repo owner

    Yep you're right, I forgot that the subsequent syncs do retrieve the title correctly.

  6. Log in to comment