Show only "Add to Pocket" command in the contextmenu when targeting links

[零欸特]

Usually, when I right-click on a link, I'm going to add the link to Pocket. I never use the "Mark as read" or the "Delete" command.

Can we have an option to decide what to show in the menu? I was able to add a link to pocket just with 2 clicks. Now I have to go to the submenu to find the command.

[Pierre-Adrien Buisson]

Hey,

Well you're the second person to tell me about this, I'll copy paste my answer here.

It's very surprising to me because, at least on Mac OS, the InMyPocket entries in the right-click menu have always been grouped into a InMyPocket "submenu", for a very very long time (as long as there's more than one entry in the menu – even disabled –, all entries are grouped in a submenu). I suppose you're using another platform, Windows or Linux, that handles the right-click menus differently.

It was not a change I knew about beforehand. I have changed the way right-click menu entries are enabled/disabled to make it more precise, it might be why it's behaving differently now. I'll try to see what I can do, maybe revert to the old way, even if it's not as good for enabling or disabling the proper menu entries... Or maybe I'll add settings for the context menu (no context menu at all or, if enabled, users could choose the submenu content). I'm not so fond of adding setting for everything so I generally try to avoid this... I'll think of it.

[零欸特]

Under Window 7 x64:

Chromium 67.0.3396.99 + In My Pocket eight04/dev-chrome

Right click on a page

Right click on a link

Firefox Dev 63.0b14 + In My Pocket 0.10.1

Right click on a page

Right click on a link

---

If the context menu isn't changed after July, it might be a platform specific bug. BTW, Firefox now supports visible property in 63+: https://bugzilla.mozilla.org/show_bug.cgi?id=1482529

[Pierre-Adrien Buisson]

Thanks for the feedback and all the screenshots, helps a lot. I'll check that out, might also have broken something myself.

[Mark Erikson]

Yep, seeing the same thing here. For the context menu, I only need to be able to "Add", or at least that's all I want at the top level of the menu.

I hadn't updated IMP in a while, just did so a few minutes ago, and now I'm seeing this. Something definitely changed code-wise to cause this.

I'm on FF60, Window 10.

update

I just manually installed 0.9.4 from addons.mozilla.org, and I now see just "Add to Pocket" when I right-click a link. Definitely something in 0.10.0 that's different.

[Pierre-Adrien Buisson]

I've worked on implementing the new visible setting for context menu entries. This way, disabled entries will be completely hidden in most recent browsers.

• For up-to-date browsers, when the page is not yet in pocket, the only option is "Add to pocket" and it should be displayed at the top level of the right-click menu,
• For up-to-date browsers, when the page is already in pocket, you'd get the "mark as read" and "delete" entries, and therefore, they'd be grouped in a "In My Pocket" submenu,
• For older browser (< FF 63), the behaviour will remain the same as the current one : only disable right-click menu entries, which can result in submenus on certain platforms even when there's only one enabled option.