Keyboard shortcut to add page broken

[Former user]

In the latest update, the quick key to "add current page or mark as read" does not appear to be functioning. Have tried to unset and set the value a few times, but still doesn't work.

[Tyler Burton]

Just left the above review, did so as anonymous by accident so adding my comment here in case there's any need for follow-up

[Pierre-Adrien Buisson]

Thanks for the feedback Tyler! Can you tell me more about :

• your FF flavor and version,
• your OS,
• maybe your keyboard layout if there's something particular,
• The shortcut you're using
• Does the shortcut to open the popup work?
• Did you try to set another shortcuts, and does it work then?

[Tyler Burton]

Hi there PIerra. Great extension. It used to work fine prior to the update.

• FF Quantum 62.0.3 (64-bit)
• Mac OS,
• Standard keyboard,
• Alt-W
• Yes, no problems with that
• Yes, and No.

Thanks.

[Pierre-Adrien Buisson]

Thanks for your feedback Tyler! I'm not sure what's happening here. I've tested IMP 0.10.1 both on latest FF (64.0.a1) and on old FF (56.2.3) and shortcut is working on both setups.

I'll download a regular FF 62 and see how it behaves.

[Pierre-Adrien Buisson]

I'm on a FF 62 right now and the shortcut is working as expected, I'm definitely missing something here. Did you check if any other addon might be using the same shortcut by chance?

Would you be so kind to follow the steps described in the last part of the FAQ and send me the browser console content...

1. when you set the shortcut
2. when you try to use it?

Maybe just paste it over here in the issue. It would definitely help me a lot to pinpoint the issue.

[Tyler Burton]

Hi Pierre, I was hopeful that one of my other extensions were causing problems, but I disabled everything and still that button doesn't work. Also, being a developer, I checked for errors thrown in the console before filing this issue, and I saw nothing logged, today I still see nothing. Super weird, eh?

Hopefully this is an issue that will eventually resolve itself and sorry I couldn't be of more help.

[Tyler Burton]

Hello Pierre, by strange coincidence I tracked down a lead this morning on the bug!

Today, I decided to check "Show 'add to pocket' button in the address bar" option, and suddenly the add current page shortcut started working.

So it seems to be tied to having that button displayed/hidden.

Hope this helps.

[Pierre-Adrien Buisson]

It does help 👍 I don't have a precise clue about what introduced this bug and how to fix it, but I can at least reproduce it and start searching more efficiently. Thanks for the help Tyler. I'll keep this issue updated when I find something.

[Pierre-Adrien Buisson]

Fixed! I'm issuing a new version right now. Thanks a lot for your help Tyler!