Problems with the Favourites feature

[Ollie Broadway]

The new Favourites feature seems rather buggy - changes don’t always stick, and I’m finding sometimes I star one item and a different item ends up starred. This applies especially if I search for an item and then try to star it from the search results. It’s a feature I will probably use a lot, but I’m not really finding it reliable enough to be usable at the moment.

[Pierre-Adrien Buisson]

Hello @Ollie Broadway , thanks for the report However, I don’t fully understand the scenario yet.

Does this always happen when you apply search? I think something’s not right in the case of filtering indeed.

Next time it happens, could you check on getpocket.com webapp if the item has been “favorited” correctly? I suspect it’s more of a display problem coupled with filtering and the way the items are rendered, but not 100% sure yet. It would help me diagnose the issue more precisely.

[Ollie Broadway]

Thanks for your response. After experimenting with this a little, it appears that you are right, and it is a display problem. After favouriting an item, and then changing the view (e.g. by clearing a search), sometimes the wrong item is displayed as favourited, or more often it doesn’t show up as favourited at all, and is missing from the filtered favourites list. Similarly, a newly unfavourited item will still display as favourited after changing the view. But the actual function of favouriting/unfavouriting an item does seem to be working correctly, and the changes display correctly after closing and re-opening the popup.

I suspect what’s happening is that the information used to decide which items to display as favourited is cached, and that cache is refreshed when the popup is closed and re-opened, but not when an item is favourited or unfavourited.

[Pierre-Adrien Buisson]

Yes this is exactly what’s happening. The cache key I was using was extremely simplistic (on purpose), but introducing favorites in the latest release made this previous solution not working anymore. I’ve fixed the problem, will make sure everything works as expected and will release an update during the course of the weekend.

[Pierre-Adrien Buisson]

Will be released in 0.11.4

[Ollie Broadway]

Thanks - just updated to the new version and it's working well now.

[Pierre-Adrien Buisson]

Great, thanks for the update 👍