in-my-pocket requires excessible browser permissions

[Julie Jones]

Currently in-my-pocket requires “Access your data for all websites” in addition to tabs and notifications. I can’t understand why it would need access to all data, which includes usernames and passwords for the websites I visit. Most of the time I won’t install extensions that require this permission and I imagine many potential in-my-pocket users have declined at this point.

‌

[Pierre-Adrien Buisson]

hello and thanks for the feedback. This permission is actually required to be able to access the url of each page visited, and therefore to display an up-to-date icon in the address bar and update its status from there. On top of my head (I’d need to confirm this), I think this is also mandatory to allow me to do the same thing in the right-click menu (where options are presented depending on the “state” of the currently shown page).

[Julie Jones]

I am trying to figure out how to build in-my-pocket. I would appreciate any tips. I assume you are amenable to pull requests. (I am impressed with your quick replies.)

[Pierre-Adrien Buisson]

Unfortunately, I’m not always so quick to reply

As for building IMP, did you check out the readme? all instructions are in there in the contribution section (that I should extract to a more standard CONTRIBUTING file for easier discovery) and seem up-to-date.

[Julie Jones]

I didn’t read the instructions. I only had a little time and I just tried to load it as a temporary extension and when that didn’t work I ran out of time. I will have more time today to read everything and see if I can get it running in developer mode so that I can experiment and hopefully contribute.

[JJ]

I cross checked required abilities with activeTab and it looks like <all_urls> is needed to be able to display the PageAction button as activeTab is onUserGesture so user first has to use command or BrowserAction and only in execution of that code you get access to Tab.url that’s required for PageAction button to work properly, other things probably could be hacked away with only this but that one is a blocker

‌

note that I’m not sure about context menu, it may also not be covered and require user to first click new position to make use of activeTab permission

[Pierre-Adrien Buisson]

Considering the current set of features, this won't be improved at the moment. The alternative would be to enable right-click actions and page actions on demand via a setting BUT have them disabled by default.

For now, I don't want to do that.