Fix middle clicking on popup items not opening in new tab

#141 Merged at e8508f5
Repository
jjzakius
Branch
Fix-middle-click
Repository
pabuisson
Branch
master
Author
  1. JJ
Reviewers
Description

Closes #30

Comments (3)

  1. Pierre-Adrien Buisson repo owner

    My bad, how did I let this bug get through… really need to work on in an integration test suite some day. Thanks for your help on this. Just not fond of mutating the function argument, other than that I’ll be happy to merge this PR and issue a fix release.

  2. JJ author

    I think the name could be better but can’t think of anything else and it’s probably good enough. And whenever you have any complaints about code style I’d gladly adhere to be consistent across project

  3. Pierre-Adrien Buisson repo owner

    Thanks for the update 🙂

    As you said, definitely good enough, even if not perfect.