1. Pierre-Adrien Buisson
  2. In My Pocket
  3. in-my-pocket
  4. Pull requests

Feature save reader

#145 Merged at a206b41
Repository
zakius
Branch
Feature-save-reader
Repository
pabuisson
Branch
master
Author
  1. JJ
Reviewers
Description
  • Allow saving of pages in Reader Mode
  • Handle Reader Mode in PageActions

Closes #17

Comments (6)

  3. Pierre-Adrien Buisson repo owner

    I’ll try to have a look into this if you’re okay with re-syncing with the master branch. Sorry for letting this go stale, I’ll try and merge it soon if you’re okay with updating the PR. Looks good to me.

  4. JJ author

    Sure, I’ll see what I can do about it but since I’m not so proficient with git I may end up creating a new one, hope you don’t mind that

  5. JJ author

    Synced and added updating of PageAction badge on item remove, I’m not sure what happened to formatting as we both use editorconfig from your repository, I’ll try to clean this up

    ‌

    edit: sorry, I can’t fix all formatting issues easily and editorconfig has pretty limited capabilities so I’m not sure how to prevent this issue from happening in the future

    1. Pierre-Adrien Buisson repo owner

      Thanks for the update. I got time this afternoon to review, had a few comments, but apart these, I think we’ll be good to merge this soon 🙂