Fix for touch screens opening items multiple times

#159 Merged at 3811987
Repository
danielrozenberg
Branch
no-double-tap
Repository
pabuisson
Branch
master
Author
  1. Daniel Rozenberg
Reviewers
Description

Some touch screens cause Firefox to fire the mouseup event multiple times, each with an increased value for the MouseEvent.detail (always starting with 1, and then +1 for each extra event. This PR fixes this issue so that using a touch screen will not open the item n times

Comments (3)

  1. Pierre-Adrien Buisson repo owner

    Sorry, really not on top of PRs and comments on the repo those days. I don’t have a non-mobile touch screen to test this so I trust you’ve tried and tested this 😉

  2. Pierre-Adrien Buisson repo owner

    And by the way, welcome and thanks a lot for your contribution 🙏 do you want me to credit you in the changelog? And if so, what should I link to, Bitbucket profile? Let me know! 🙂

  3. Daniel Rozenberg author

    No worries about the delay, I figured you work on this project in your free time and don’t always pay attention to it.

    Yes, I tested it on a touchscreen Linux and touchscreen Windows, and in both cases the fix works with both touch and standard mouse as expected.

    And yes, I would be happy to get credit in the changelog - I don’t have anything public on my Bitbucket so my GitHub account would be good - https://github.com/danielrozenberg

    Thanks!