#35 Merged at c94b957
Repository
eight04
Branch
dev-title
Repository
pabuisson
Branch
master
Author
  1. 零欸特
Reviewers
Description

I added the page action just like old pocket addon.

Also an option to open random item after read.

I don't know how to use icon font, so I left an "R" in popup.html.

Comments (5)

  1. Pierre-Adrien Buisson repo owner

    Wow lots of stuff in your PR. First, thanks a lot for contributing :)

    I don't really know when I'll have the time to test and review this, lots of things happening at the moment to be honest, and I've got a problem with mozilla addon review process that's taking forever those days (I think I've submitted a new version 3 weeks ago, and I'm only 130th in the review queue...). I'll do it as soon as I've got some free time... but I'll do it :)

  2. Pierre-Adrien Buisson repo owner

    Haha sorry for the 1st comment, I thought I could publish all my comments at once. I'll try to test and review your PR this week, thanks again and sorry for not doing it faster :)))

  3. Pierre-Adrien Buisson repo owner

    Hey ! I've been testing your PR this week, works great, except for settings, the checkboxes seem not to load anymore. Is it just on my Firefox or same for you? Otherwise everything looks pretty awesome!

    Only, to be honest, I won't ship the "open random page after marking a page as read" feature. I can see the point, but it looks like a very edge-case to me, and I'd like to keep the addon as lean as possible (the alternative scenario would just be "open list and hit random after I read something", so I think it's a decent trade-off). So I think I'll merge the code but won't ship this particular feature and setting.

    However, I really like everything else, hadn't really thought of the "open random link" feature but it's pretty cool. And the page action is great, I love it 👍 I think I'll add dedicated and "simpler" icons for the page action, but it's a small amount of work, I'll do this asap.

    Please, just let me know if you encounter the same "settings" issue as I do, and I'll merge your PR right after this. Make sure it's correctly rebased on master before and that'll be all good.

    git checkout your-branch git fetch -p git rebase origin/master

    BTW, can I "credit" you in the addon changelog? Under what name or pseudo?

    1. 零欸特 author

      These options were introduced from old pocket addon.

      • Open a random item after "mark as read":

        http://i.imgur.com/11Tf92E.png

      • A button to open a random item:

        http://i.imgur.com/HEH2MQ3.png

      • Open in new tab:

        http://i.imgur.com/yBInkkD.png

      While reading posts from the list, I usually:

      1. Open a random item
      2. Mark as read, and open another random item.
      3. Go to step 2.

      There is another feature I didn't implement that "open a random item" should obey the search filter, so the item is grabbed from the search result.

      the checkboxes seem not to load anymore.

      Same here with Firefox 55.0b2.

      can I "credit" you in the addon changelog? Under what name or pseudo?

      Sure. In other projects, I have seen they adding a link to the PR in the changelog, which is enough IMHO.

  4. Pierre-Adrien Buisson repo owner

    There is another feature I didn't implement that "open a random item" should obey the search filter, so the item is grabbed from the search result.

    Indeed. Will look after this!