#71 Merged at 977c4db
Repository
kEINnAMER
Branch
FEATURE/favicon
Repository
pabuisson
Branch
master
Author
  1. Pavel Gavlík
Reviewers
Description

Others:

  • fix some ESLint warnings in popup.js

Comments (5)

  1. Pavel Gavlík author

    Hi! I've just switched to Firefox and found this great extension. I missed favicons in page list, so I've created this little PR. Happy to do any changes to get this merged.

  2. Pierre-Adrien Buisson repo owner

    Hi Pavel! Thanks for the PR. I haven't had much time lately, but I hope I'll find some this week to merge and release a new version of IMP and check your PR. Thanks a lot for your help anyway, and I've not forgotten your PR, just need to take some time to test it :) I'll keep you posted, hopefully this week or weekend. Cheers

  3. Pierre-Adrien Buisson repo owner

    Hi Pavel, just checked your code and tested a bit, it's great (sorry for the delay!). I think you'll have to fetch latest changes on my repo's master and rebase your branch on the up-to-date master before we can merge (there's a conflict there because you've fixed indentation and I've removed some calls to Badge.updateCount() in the same time).

    Thanks again for your contribution 👍

  4. Pierre-Adrien Buisson repo owner

    Great! Last thing : how do you want to be credited in the changelog / addon release note? "Pavel Gavlík" or "kEINnAMER"? Let me know some time.