Issue #39 resolved

PetscOptionsInsertFile() corrupts memory for large files

BarryFSmith avatarBarryFSmith created an issue

PetscOptionsInsertFile() writes past the end of the vstring and astring buffers if there are many options and aliases in the file.

Needs to be reworked to prevent going past the end of the buffers

Comments (4)

  1. Jed Brown

    PetscOptionsInsertFile: fix overflow for large file sizes [fix #39]

    New implementation uses PetscSegBuffer to incrementally allocate storage for all the options. This also fixes the O(n^2) complexity arising from repeated calls to strcat() in the old version.

    → <<cset e24ecc5dc0ec>>

  2. Log in to comment
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.