1. petsc
  2. PETSc
  3. petsc
  4. Issues
Issue #39 resolved

PetscOptionsInsertFile() corrupts memory for large files

BarryFSmith
created an issue

PetscOptionsInsertFile() writes past the end of the vstring and astring buffers if there are many options and aliases in the file.

Needs to be reworked to prevent going past the end of the buffers

Comments (4)

  1. Jed Brown

    PetscOptionsInsertFile: fix overflow for large file sizes [fix #39]

    New implementation uses PetscSegBuffer to incrementally allocate storage for all the options. This also fixes the O(n^2) complexity arising from repeated calls to strcat() in the old version.

    → <<cset e24ecc5dc0ec>>

  2. Log in to comment