Enable edit and delete from search

[Former user]

Originally reported on Google Code with ID 138

Currently the search only allows you to view results, you cannot edit or delete a row
from the search page. If I need to edit a certain row I have to view all rows on one
page and then ctrl+f to find it, instead I'd like to be able to edit from a search

Reported by Paroxsitic on 2012-11-09 00:46:41

[Former user]

Yep, i agree!
2 columns "edit" and "delete" should be added to search result.

Reported by teryaki1963 on 2012-11-09 20:20:00

[Christopher Kramer]

Agreed.

Reported by crazy4chrissi on 2012-11-10 13:32:50 - Status changed: Accepted

[Christopher Kramer]

Reported by crazy4chrissi on 2012-11-10 13:44:07 - Labels added: Type-Enhancement

[Former user]

Edit and Delete: fixed

See last svn: http://phpliteadmin.googlecode.com/svn-history/r286/source/1.9.4/phpliteadmin.php

Reported by teryaki1963 on 2012-11-15 15:03:13

[Christopher Kramer]

Thanks!

I implemented this a bit easier/better. We do not need a second query for this, we
can do:
SELECT *,ROWID FROM ... WHERE...
If you use 2 queries, the rowids might get inconsistent with the actual rows if another
user performs some statement that changes a rowid. If you use 2 queries here, you'd
need to use a transaction to be on the safe side.

Otherwise, you might delete another row as you clicked on for example.

Because using your getRowId-function always has this problem, I removed it altogether.

Reported by crazy4chrissi on 2012-11-15 15:31:00 - Status changed: Fixed

[Former user]

i tried it now, but pk has no value!

Reported by teryaki1963 on 2012-11-15 15:52:51

[Christopher Kramer]

Hmm... strange. It should work as I implemented it nearly exactly the same way as the
"browse" tab does.

Could you mail me your db and what you searched for?

Reported by crazy4chrissi on 2012-11-15 15:56:31

[Former user]

Reported by teryaki1963 on 2012-11-16 11:07:02 - Status changed: Accepted

[Christopher Kramer]

Okay, I reverted my changes because they broke things. I or someone else should do this
properly someday, but it is not urgent. So I opened another issue (issue #144) so we
won't forget this and will correct it someday.

But in principle, this issue here is fixed.

Reported by crazy4chrissi on 2012-11-16 16:21:18 - Status changed: Fixed

[Former user]

yah, but it seems not the same. There are errors in last changes.
See the difference (image) between the one i have (2) and the latest svn (1).

I'll save mine again, if you like?

Reported by teryaki1963 on 2012-11-16 19:29:31

<hr> * Attachment: issue_138.png<br>

[Christopher Kramer]

Ah, I forgot to replace "both" with "assoc". Wait.

Reported by crazy4chrissi on 2012-11-16 19:46:13

[Christopher Kramer]

Correct now?

Reported by crazy4chrissi on 2012-11-16 19:47:57

[Former user]

yep, thx :)

Reported by teryaki1963 on 2012-11-16 19:51:10

[Christopher Kramer]

Issue 154 has been merged into this issue.

Reported by crazy4chrissi on 2012-11-22 23:17:47

[Christopher Kramer]

Reported by crazy4chrissi on 2013-03-09 17:10:35

[Former user]

I had originally requested for the Browse tab the feature was added in just a couple
days after that - thanks!. I don't see why the same code could not easily be pasted
into the search routine? 

Thanks for all the hard work :)

Reported by [e-mail] on 2013-03-10 18:21:24