2 typos: "is_readeable" (unknown function) and index j vs. i in dev. 1.9.4

[Former user]

Originally reported on Google Code with ID 180

double misspell

see patch

Reported by ykorotia on 2013-02-26 09:39:10

<hr> * Attachment: phpliteadmin.php.patch

[Christopher Kramer]

Thanks. "is_writeable" is okay, as there is an alias:
http://de.php.net/manual/en/function.is-writeable.php

is_readeable obviously is a typo. Thanks, I'll fix it (both).

Reported by crazy4chrissi on 2013-02-26 10:01:14 - Status changed: Accepted

[Christopher Kramer]

This bug was introduced in Rev r336 while Fixing issue #175.

Reported by crazy4chrissi on 2013-02-26 10:07:55 - Status changed: Started

[Christopher Kramer]

This issue was closed by revision r342.

Reported by crazy4chrissi on 2013-02-26 10:11:23 - Status changed: Fixed

[Former user]

you're welcome. great project

I've changed is_writeable only to match is_readable. Under second typo I meant index
'j', you probably meant 'i'. At least after change it works for me :)

Reported by ykorotia on 2013-02-26 10:25:05

[Christopher Kramer]

Ah, thanks for making me aware of this.
i only looked at your patch in the google website and did not spot the i-vs-j mistake
(because the small change it is hard to see without graphical highlighting). Should
have applied your patch to spot it.

I just fixed the index-problem.

Reported by crazy4chrissi on 2013-02-26 10:33:37

[Christopher Kramer]

We should clearly reduce the copy&paste amount in phpLiteAdmin. Both typos are kind
of copy-and-paste related: is_readeable was a typo I copied, spotted the mistake, but
corrected it only at one place. The index is i at one place, j at the other, which
I did not see when copying.

To avoid this kind of mistakes, we should go on improving the structure so less copy&paste
is necessary and the code becomes more easy to maintain.

Reported by crazy4chrissi on 2013-02-26 10:40:46

[Former user]

yep. that's good, 'cause I've created bad patch (it was within 1.9.4 directory, wrong
headers)

hehe

Reported by ykorotia on 2013-02-26 10:48:02