A lot of source/asset files are executable which shouldn't be executable

Issue #36 resolved
compyx created an issue

I noticed the Makefile in the root directory having its executable set, which it shouldn’t have. So I scanned the files with find . -type f -executable | sort and found the following executable files:

./data/img/edit.png
./driver/driver.h
./driver/video/cgl.cpp
./driver/video/thread/renderThread.cpp
./emulation/cia/base.cpp
./emulation/cia/base.h
./emulation/cia/m6526.cpp
./emulation/cia/m6526.h
./emulation/cia/m8520.cpp
./emulation/cia/m8520.h
./emulation/cia/new/cia.cpp
./emulation/cia/new/cia.h
./emulation/cia/new/defines.h
./emulation/cia/new/register.cpp
./emulation/cia/new/tod.cpp
./emulation/cia/register.cpp
./emulation/libc64/disk/iec.cpp
./emulation/libc64/disk/iec.h
./emulation/libc64/expansionPort/easyFlash/easyFlash.cpp
./emulation/libc64/expansionPort/easyFlash/easyFlash.h
./emulation/libc64/expansionPort/expansionPort.h
./emulation/libc64/expansionPort/retroReplay/memoryHandler.cpp
./emulation/libc64/expansionPort/retroReplay/retroReplay.cpp
./emulation/libc64/expansionPort/retroReplay/retroReplay.h
./emulation/libc64/expansionPort/reu/reu.cpp
./emulation/libc64/expansionPort/reu/reu.h
./emulation/libc64/sid/envelope.cpp
./emulation/libc64/sid/multisid.cpp
./emulation/libc64/sid/register.cpp
./emulation/libc64/sid/serialization.cpp
./emulation/libc64/sid/sid.cpp
./emulation/libc64/sid/sid.h
./emulation/libc64/sid/voice.cpp
./emulation/libc64/system/gluelogic.h
./emulation/libc64/system/serialization.cpp
./emulation/libc64/system/system.cpp
./emulation/libc64/system/system.h
./emulation/tools/systimer.h
./.git/hooks/applypatch-msg.sample
./.git/hooks/commit-msg.sample
./.git/hooks/fsmonitor-watchman.sample
./.git/hooks/post-update.sample
./.git/hooks/pre-applypatch.sample
./.git/hooks/pre-commit.sample
./.git/hooks/pre-merge-commit.sample
./.git/hooks/prepare-commit-msg.sample
./.git/hooks/pre-push.sample
./.git/hooks/pre-rebase.sample
./.git/hooks/pre-receive.sample
./.git/hooks/push-to-checkout.sample
./.git/hooks/update.sample
./guikit/cocoa/main.cpp
./guikit/cocoa/versioning.cpp
./guikit/cocoa/widgets/listview.cpp
./guikit/cocoa/widgets/slider.cpp
./Makefile
./program/emuconfig/layouts/firmware.cpp
./program/emuconfig/layouts/firmware.h
./program/media/autoloader.cpp
./program/media/autoloader.h
./program/view/view.cpp
./program/view/view.h

This usually is a result of committing files from Windows (I’m on Linux here).

Comments (4)

  1. compyx reporter

    I think git config --global core.fileMode false will work. Git will ignore any file mode bits, so you’ll manually have to set executable bits for files that do need it, with something like git update-index --chmod=+x some.file.

  2. Log in to comment