Proposal: put the default values in JXM even if they are not changed.

[Former user]

Hi, Great plugin works really nice and had a lot of features. Great work! There is couple of things I would like to see changes.

This would make easier a copy and replace in the JMX file. For example this part of default read sampler:

                <boolProp name="binaryPayload">false</boolProp>
                <boolProp name="createNewConnection">false</boolProp>
                <boolProp name="optional">false</boolProp>
              </eu.luminis.jmeter.wssampler.SingleReadWebSocketSampler>

And this how it looks if value is changes from default

                <boolProp name="binaryPayload">false</boolProp>
                <boolProp name="createNewConnection">false</boolProp>
                <boolProp name="optional">false</boolProp>
<stringProp name="readTimeout">6666</stringProp>
              </eu.luminis.jmeter.wssampler.SingleReadWebSocketSampler>

Having all XML tags in JMX even with default values would make it easier for adding parameters and performing a copy replace.

[Peter Doornbosch]

do not pass default values to setProperty, because this causes default values to be removed from the test plan xml. This fixes issue #68, https://bitbucket.org/pjtr/jmeter-websocket-samplers/issues/68/proposal-put-the-default-values-in-jxm

→ <<cset 98fc6de944e7>>

[Peter Doornbosch]

Merge branch 'master' into multiple-connections

• master: (22 commits) include type of received frame in “unexpected frame type” error improve receive performance fix test added organization url fix: when responding to ping frame, the pong must have identical application data as found in the ping changed message for ping/pong frame without application data fix: ping filter should not respond to a pong. added option to filter pong frames only added sample use standard JMeter file dialog, to have consistent behaviour w.r.t. the directory the dialog opens with updated docs do not pass default values to setProperty, because this causes default values to be removed from the test plan xml. This fixes issue #68, https://bitbucket.org/pjtr/jmeter-websocket-samplers/issues/68/proposal-put-the-default-values-in-jxm updated docs added option to read request data from file (change request #62, https://bitbucket.org/pjtr/jmeter-websocket-samplers/issues/62/reading-outgoing-payload-from-a-file-in) fix: correct parsing of JMeter variables in input fields to avoid false syntax errors. This fixes issue 67 https://bitbucket.org/pjtr/jmeter-websocket-samplers/issues/67/change-request-accept-string-jmeter refactor: let format method handle elipsis suffix refactor: reduce duplicate code in samplers updated UI code to support loading data from file refactor added option to filter ping frames only ...

Conflicts:

README.md

src/main/java/eu/luminis/jmeter/wssampler/PingFrameFilter.java

src/main/java/eu/luminis/jmeter/wssampler/SingleWriteWebSocketSampler.java

src/main/java/eu/luminis/jmeter/wssampler/WebSocketSamplerGuiPanel.java

→ <<cset 53d666dc2590>>