Request to complete the continuation frames branch

Peter Doornbosch repo owner

Hi,

I guess you are referring to https://bitbucket.org/pjtr/jmeter-websocket-samplers/branch/continuation-frames-2, which contains a SingleReadMessageSampler that can read one websocket message (which might consist of several frames).

Completing this functionality and make it production ready will be a lot of work, because the current (stable) version of the plugin works on Frames, not messages. As a consequence, i would have to rewrite all filter related functionality before i can complete this branch. Also, the result would be incompatible with the current version.

Currently i don't have the time to do so. Please note that i do and have done all development on this plugin in my spare time, and sometimes i have other priorities. I have a personal life and a normal day job too, you know ;-).

Having said that, the current version of the plugin does support continuation frames, but in a different way: as a test script author, you'll have to take it into account as explained in the documentation.

I understand that you like the version in the branch better (i do!). If other people would like to have this functionality too, they should vote for this issue; if it gets a lot of votes, that would encourage me to spend time on it. However, as explained, no guarantees.

With respect to your wish to reap the bug fixes of master, we could try to merge master into the continuation branch. If we are lucky, this wouldn't be too much work and you'd have best of both worlds.

Regards Peter

2018-10-24T16:16:45+00:00

Comments (3)

Peter Doornbosch repo owner
Hi,

I guess you are referring to https://bitbucket.org/pjtr/jmeter-websocket-samplers/branch/continuation-frames-2, which contains a SingleReadMessageSampler that can read one websocket message (which might consist of several frames).

Completing this functionality and make it production ready will be a lot of work, because the current (stable) version of the plugin works on Frames, not messages. As a consequence, i would have to rewrite all filter related functionality before i can complete this branch. Also, the result would be incompatible with the current version.

Currently i don't have the time to do so. Please note that i do and have done all development on this plugin in my spare time, and sometimes i have other priorities. I have a personal life and a normal day job too, you know ;-).

Having said that, the current version of the plugin does support continuation frames, but in a different way: as a test script author, you'll have to take it into account as explained in the documentation.

I understand that you like the version in the branch better (i do!). If other people would like to have this functionality too, they should vote for this issue; if it gets a lot of votes, that would encourage me to spend time on it. However, as explained, no guarantees.

With respect to your wish to reap the bug fixes of master, we could try to merge master into the continuation branch. If we are lucky, this wouldn't be too much work and you'd have best of both worlds.

Regards Peter
- 2018-10-24T16:16:45+00:00
Peter Doornbosch repo owner
- changed status to open
- 2018-11-19T17:39:43+00:00
Alexander Barker reporter
Hi Peter,

Sure I understand... we all have lives to live. My daughter is a like a gremlin that never get's enough attention :)

Right now I have a work around to handle the extra frames, but it's not nice.

If you could rebase it with master however, that would be great!

Best regards and thanks again for your contribution :) Alex
- 2019-07-24T10:25:15+00:00
Log in to comment