youtube adapter seems broken

[Former user]

I think the youtube adapter is broken in the moment. It will never return cached feeds if they aren't updated in this request. This is due to the fact that "$result[] = $feed;" is only assigned inside the if clause in YoutubeAdapter::getResultFromApi() (Line 152) that determines if a cache entry needs to be updated. The assignment needs to be moved out of the if clause to be the last before the loop continues. Otherwise $result will be empty and this method returns only feeds if they are updated or created but not if they are unchanged.