Peter Hosey avatar Peter Hosey committed a1f37df

Modified version of a patch from ahihi on the discuss list, releasing the string we get containing the raw image data.

The Python internal library does not follow Core Foundation naming rules. PyObject_GetAttrString returns an ownership, which we must release. <http://docs.python.org/release/2.6/c-api/object.html&gt;

Comments (0)

Files changed (1)

Bindings/python/libgrowl.c

 				CFDataRef convertedValue = CFDataCreate(kCFAllocatorDefault,
 														(const UInt8 *)PyString_AsString(lValue),
 														PyString_Size(lValue));
+				Py_DECREF(lValue);
 				CFDictionarySetValue(note, convertedKey, convertedValue);
 				CFRelease(convertedValue);
 			} else {
+				Py_DECREF(lValue);
 				CFRelease(convertedKey);
 				PyErr_SetString(PyExc_TypeError, "Icon with rawImageData attribute present must ensure it is a string.");
 				goto error;
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.