Commits

Author Commit Message Labels Comments Date
Peter Hosey
Removed this #import added in c5d8e9cdac78. Turns out we don't need to import the hgRevision header into the Info.plist prefix header at all—apparently, neither of the framework Info.plists use it. I have no idea why they were set to use it as their Info.plist prefix header. Moreover, importing it breaks pretty much everything else.
Branches
default
Peter Hosey
Add the hg revision script target as a dependency of the GrowlMenu target. Fixes release builds.
Branches
default
Peter Hosey
Increasing version to 1.2b6.
Branches
default
Peter Hosey
Fixed spacing between notification windows. The fix was to modernize the return type in the declaration of -requiredDistanceFromExistingDisplays in GrowlPositionController's informal protocol for display window controllers, which we had somehow missed in 8+ revisions of the 64-bit patch. With this declared as returning float, it caused subclass implementations—even those already correctly typed as returning CGFloat—to always return zero whe…
Branches
default
Peter Hosey
Turning the static analyzer back off, since it takes awhile on the GrowlPluginController.
Branches
default
Peter Hosey
When an error occurs while loading a plug-in, log it. Bug found by the analyzer.
Branches
default
Peter Hosey
Don't leak plug-in instances. Found by the analyzer.
Branches
default
Peter Hosey
Burninating GrowlNonCopyingMutableDictionary in favor of NSMapTable, since that's now a Cocoa class.
Branches
default
Peter Hosey
Fix a bug found by the static analyzer: We do not own this timer, and we were (technically) leaking it. We now correctly manage its lifetime.
Branches
default
Peter Hosey
Turn on the static analyzer.
Branches
default
Peter Hosey
Always use NSIntegerMapValueCallbacks, regardless of architecture, since we require Leopard anyway. Fixes a warning when compiling for 32-bit.
Branches
default
Peter Hosey
Declare this method, fixing a warning.
Branches
default
Peter Hosey
Make this method conform to Cocoa coding style by not using Apple's reserved prefix.
Branches
default
Peter Hosey
Declare GHA as requiring 10.6 to run x86_64. Fixes it running x86_64 on 10.5.x.
Branches
default
Peter Hosey
Er, yeah. I can't just have this include search path in the framework targets—it needs to be in all of the project objects.
Branches
default
Peter Hosey
Changed the framework targets to use the same Info.plist prefix header as the other targets, and imported the hgRevision header into that header. Fixes Growl.framework's version number being “GROWL_VERSION”.
Branches
default
Peter Hosey
Use a simple swap, not a three-point swizzle, in the hope of interacting better with other Mail bundles that have preferences (such as MailActOn).
Branches
default
Peter Hosey
Use AESendMessage, which comes from CoreServices, not AESend, which comes from Carbon.
Branches
default
Peter Hosey
This is an Apple Event, not a Carbon Event, so we want keyDirectObject, not kEventParamDirectObject.
Branches
default
Peter Hosey
Let's do one more beta.
Branches
default
Peter Hosey
Switched from using Launch Services to open the .growlRegDict file to sending GHA the open-document event ourselves. This seems to fix the bug where GrowlSafari registering yanks the user out of Safari.
Branches
default
Peter Hosey
Increased version to 1.2, and shut off the beta switch.
Branches
default
Peter Hosey
Rewrote the error message text for the this-plug-in-won't-work error to be more understandable for less-experienced users.
Branches
default
Peter Hosey
Add a build configuration for localization builds.
Branches
default
Rudy Richter
GPC: check to see if there is an executable file in the bundle first, if there is then check its architectures, if not then its either a growlStyle or something else. either way it fulfills the architecture requirements
Branches
default
Peter Hosey
Increased version to 1.2b4.
Branches
default
Peter Hosey
Set the bounds of the disk image volume window. I'm not sure why this was commented out. Not only have I uncommented it, I also changed the value.
Branches
default
Peter Hosey
Fixed one problem with the dmg script: The Growl package is now named Growl.pkg, not Growl.mpkg as the script was expecting. This is what was causing the icon positions to not get set.
Branches
default
Peter Hosey
Newline at end of file.
Branches
default
Peter Hosey
Changes to the GrowlSafari Installer package to quit GrowlSafari before installing and relaunch it after installing.
Branches
default
  1. Prev
  2. Next