1. Perry Metzger
  2. growl

Commits

Author Commit Message Date Builds
bgannin
GrowlMail's version should be 1.1.3, and copyright extended to 2008.
Branches
default
boredzo
Fixed property-list format of GrowlTunes' German Localizable.strings. An equals sign (=) must separate keys and values; a hyphen-minus (-) is invalid, and will break the build.
Branches
default
bgannin
Update version for beta 4.
Branches
default
boredzo
Because we can't create a PNG from a 1-bit image, we must ignore any 1-bit image reps. In order to not ignore images that are *only* available in 1-bit, we now support TIFF as a fallback to PNG. When this happens, the data: URL changes to carry image/tiff instead of image/png as the media type, and to carry the TIFFRepresentation rather than the (nil) PNGRepresentation as the data. Accordingly, I renamed -[NSImage GrowlBitmapImageRep] to -GrowlBitmapImageRepForPNG. It returns nil w…
Branches
default
boredzo
Set the maxWidth variable when we find a larger image rep than the one we had previously. Otherwise, we simply end up with the last image rep in the array; the width comparisons have no effect. This bug would cause the WebKit display to sometimes show a '?' when the source image is in the IconFamily format, because IconFamily images can contain a 1-bit representation, and that representation is usually last when it's present. This fix is only partial: it's still possible for this method to let a 1-bit rep win, which will cause the '?' again.
Branches
default
boredzo
We now record all notifications from all pathways in a central location: ~/Library/Application Support/Growl/Saved Notifications. That directory contains one subdirectory per day, and each of those subdirectories contains plist files which are named in the pattern “Growl saved notification #NUMBER.plist” (where NUMBER increases monotonically from 0). Naturally, this is restricted to the main thread, in order to avoid two notifications from different sources running into each other in attempting to save their respective notification files.
boredzo
Branched to add code to record notifications to plist files. If we ever want to add replay functionality, this is probably the easiest way to do it (easier than the log file); I'm doing it now so that I can use it to debug the weirdly-small-images problem.
boredzo
Fixed this assumption that GrowlPluginInfoKeyName is equal to kCFBundleNameKey.
Branches
default
boredzo
Fixed an exception which caused a hang. I don't know what the previous code was supposed to be doing, but the correct code is much simpler: get the dictionary (which we were using as a property key), and assign that to the variable.
Branches
default
boredzo
Committed workaround to conflict with Logitech Control Center 2.4, as discussed on the list.
Branches
default
boredzo
Found the problem: The return statement for bailing out of posting a notification when a copy was underway was guarded (I think accidentally) by an #ifdef that was only supposed to protect debug messages. Moving the return statement below the #endif (or the #endif above the return—whatever the diff algorithm prefers) fixes the bug.
Branches
default
boredzo
Added debug messages to help me figure out why GrowlMail was posting notifications for message moves and copies.
Branches
default
boredzo
Added suicide-pill guards for cases where the messageCopies variable underflows or overflows.
Branches
default
boredzo
Xcode 2.5 helpfully corrected the UTIs of a few strings files for me.
Branches
default
evands
revert part of [2716] which made webkit override shouldDelayWindowOrderingForEvent 'so that the notifications are not ordered front when clicked.' without overriding this, we still don't switch the active application, and its overriding breaks any change in window focus or application activity which happens within the event's invocation's run loop -- which includes an application switching to be active in response to a click. Fixes Adium Trac ticket 9494
Branches
default
boredzo
Changed GrowlApplicationController to use the SystemSound API to play sounds. Downside: We've now reinvented the finding-sounds-by-name wheel (previously done for us by +[NSSound soundNamed:]). Upside: We now use the Default System Output Device rather than the Default Output Device.
Branches
default
boredzo
Fixed the warning on launch about the the Growl UDP pathway being unable to bind the socket. This happened since [4803] when Growl was set to listen for forwarded notifications. It didn't happen before that revision because we terminated before the pathways were instantiated (also before any documents were opened, which was the problem it fixed). More specifically: Moved -[GrowlApplicationController initSingleton]'s instantiation of the GrowlPathwayController above its call to -preferencesChanged:, because -preferencesChanged: was instantiating the GPC anyway. In that same section, made -initSingleton responsible for checking whether another GHA was already running. Made -preferencesChanged: not instantiate the GPC when the quitAfterOpe…
Branches
default
boredzo
Changed -runningHelperAppBundle to not call bundleWithIdentifier:, so that it isn't dependent on whether a bundle with that identifier was ever previously instantiated from another method.
Branches
default
evands
Find the largest rep when looking for a bitmap image rep
Branches
default
boredzo
The fix in [4803] doesn't really register apps still using the old GAB; it will save a ticket for them, but the running GHA won't know about the ticket until it next relaunches. The correct behavior in that case is to reopen the .growlRegDict file with the running GHA, so that the application really does get registered with it immediately.
Branches
default
boredzo
Made +runningHelperAppBundle public, and documented it, and updated the documentation of +helperAppBundle and +growlPrefPaneBundle to note that they use it.
Branches
default
boredzo
Delegate the opening of .growlRegDict files to a new GrowlPropertyListFilePathway, and only terminate the app one second after the last file is processed. This fixes, GrowlHelperApp-side, the bug where a bunch of .growlRegDict files get left in the Temporary Items folder. This was caused by GAB launching the .growlRegDict files with the GHA in ~/Library, when the GHA in /Library was the one running, and by GHA-in-~/Library bailing before it processed the files. A GHA with this fix will (a) process all files it was launched with, not just the first o…
Branches
default
boredzo
Removed a Copy Files phase from the prefpane target, because I don't think we need to put headers into the Resources folder of the prefpane.
Branches
default
boredzo
GrowlPathUtilities' search for the GrowlHelperApp bundle now looks for a running GHA process first. If found, it returns the bundle for that process. This fixes, framework-side, the bug where a bunch of .growlRegDict files get left in the Temporary Items folder. This was caused by GAB launching the .growlRegDict files with the GHA in ~/Library, when the GHA in /Library was the one running, and by GHA-in-~/Library bailing before it processed the files. Frameworks with this fix will use the running GHA, thereby correctly registering the app and n…
Branches
default
boredzo
Corrected definition of GROWL_HELPERAPP_BUNDLE_IDENTIFIER to actually use the correct name.
Branches
default
boredzo
Renamed HelperAppBundleIdentifier to GROWL_HELPERAPP_BUNDLE_IDENTIFIER, and moved it to GrowlDefinesInternal.h (just below GROWL_PREFPANE_BUNDLE_IDENTIFIER).
Branches
default
boredzo
Include the PID in the registration-dictionary filename, to aid testing.
Branches
default
evands
Fix naming conflict on 10.5+; bitmapImageRep is used, and we want our own implementation.
Branches
default
evands
Removed deleted header reference
Branches
default
boredzo
-[NSImage TIFFRepresentation] is expensive. *Very* expensive (90% of the CPU time in last night's Shark run on GrowlTunes - in fact, TIFFRepresentation was the reason why invoking registrationDictionaryForGrowl needlessly was so expensive). Let's not call it unless we need to.
Branches
default
  1. Prev
  2. Next