Commits

Patrick Mézard committed 019bbe4

codereview: remove broken CL.copied_from field

I broke it while refactoring because the email matching game involved
CONTRIBUTORS which seemed a bit irrelevant. The feature will probably come back
in another form later.

Comments (0)

Files changed (1)

lib/codereview/codereview.py

 		self.url = ''
 		self.local = False
 		self.web = False
-		self.copied_from = None	# None means current user
 		self.mailed = False
 		self.private = False
 		self.lgtm = []
 	def DiskText(self):
 		cl = self
 		s = ""
-		if cl.copied_from:
-			s += "Author: " + cl.copied_from + "\n\n"
 		if cl.private:
 			s += "Private: " + str(self.private) + "\n"
 		s += "Mailed: " + str(self.mailed) + "\n"
 		if sys.platform == "win32" and os.path.isfile(path):
 			os.remove(path)
 		os.rename(path+'!', path)
-		if self.web and not self.copied_from:
+		if self.web:
 			EditDesc(self.name, desc=self.desc,
 				reviewers=JoinComma(self.reviewer), cc=JoinComma(self.cc),
 				private=self.private)
 		sections[k] = StripCommon(sections[k]).rstrip()
 
 	cl = CL(name)
-	if sections['Author']:
-		cl.copied_from = sections['Author']
 	cl.desc = sections['Description']
 	for line in sections['Files'].split('\n'):
 		i = line.find('#')
 		cl.dict = d
 		cl.reviewer = d.get('reviewers', [])
 		cl.cc = d.get('cc', [])
-		if cl.local and cl.copied_from and cl.desc:
-			# local copy of CL written by someone else
-			# and we saved a description.  use that one,
-			# so that committers can edit the description
-			# before doing hg submit.
-			pass
-		else:
-			cl.desc = d.get('description', "")
+		cl.desc = d.get('description', "")
 		cl.url = server_url_base + name
 		cl.web = True
 		cl.private = d.get('private', False) != False