Commits

Patrick Mézard  committed a680deb

codereview: really separate data from meta-data upload

  • Participants
  • Parent commits 0dc1585

Comments (0)

Files changed (1)

File lib/codereview/codereview.py

 		ui.status(msg + "\n")
 		self.name = msg[msg.rfind("/")+1:]
 		self.url = server_url_base + self.name
-		self.UploadMeta()
 
 	def Upload(self, ui, repo, ctx, quiet=False):
 		if not self.files:
 					upload_options)
 		set_status("uploading base files")
 		UploadBaseFiles(self.name, rpc, patches, patchset, upload_options, files)
-		self.UploadMeta()
 
 	def Mail(self, ui, test=False):
 		pmsg = "Hello " + JoinComma(self.reviewer)
 		cl.files = list(ctx.files())
 		cl.Create(ui)
 
+	cl.Upload(ui, repo, ctx, quiet=creating)
 	cl.UploadMeta()
-	cl.Upload(ui, repo, ctx, quiet=creating)
 
 	newdesc = addclmeta(cl, ctx.description())
 	if newdesc != olddesc:
 			raise hg_util.Abort("no reviewers listed in CL")
 		cl.cc = Sub(cl.cc, defaultcc)
 		cl.reviewer = defaultcc
-		cl.UploadMeta()
+	cl.UploadMeta()
 
 	if not cl.files:
 		raise hg_util.Abort("no changed files, not sending mail")