Issue #3 resolved

hg mimport reports incorrect error on non-existent mboxes

Shlomi Fish
created an issue

Dear sirs,

After adding the following lines to my .hgrc: {{{ [extensions] mbox = /home/shlomif/Download/unpack/file/vcs/hgmbox/hgmbox/mbox.py hgext.mq = [mbox] mbox.FOO.path = /home/shlomif/patch.mbox }}}

I am getting the message "0 patches imported" on every invocation of hg mimport, including for non-existing mail boxes:

{{{ shlomif[XML-LibXML]:$trunk$ hg mimport FOO 0 patches imported shlomif[XML-LibXML]:$trunk$ hg mimport vav 0 patches imported shlomif[XML-LibXML]:$trunk$ hg mimport vavvavava 0 patches imported shlomif[XML-LibXML]:$trunk$ hg mimport vav 0 patches imported shlomif[XML-LibXML]:$trunk$ hg mimport FOO 0 patches imported shlomif[XML-LibXML]:$trunk$ hg mimport this_does_not_exist 0 patches imported }}}

This is wrong - hg mimport should detect if it cannot find the mbox and report it with an error.

All that is besides the fact that I'm getting "0 patches imported" also with the legitimate mbox containing the patch.

Regards,

— Shlomi Fish

Comments (2)

  1. Anonymous

    Hello,

    The command:

    hg mimport PATTERN
    

    attempts to import a patch "matching" PATTERN from any configured email source. "Matching" means the pattern is interpreted as a python regular expression and is applied to messages title and possible introduction messages.

    Does this help? -- Patrick

  2. Log in to comment