Luke Plant avatar Luke Plant committed e0417f0

Code simplification

Comments (0)

Files changed (1)


         if len(links_cache) > 0:
             return links_cache
-            links = list(MenuLink.objects.filter(parent_item__isnull=True, visible=True))
-            for l in links:
+            for l in MenuLink.objects.filter(parent_item__isnull=True, visible=True):
                 l.title = standard_subs(l.title)
                 l.isCurrentPage = False
                 l.isCurrentSection = False
                     l.isCurrentPage = True
                 elif request_path.startswith(l.url) and l.url != u'/':
                     l.isCurrentSection = True
-            links_cache.extend(links)
-            return links
+                links_cache.append(l)
+            return links_cache
     context['menulinks'] = get_links
     context['GOOGLE_ANALYTICS_ACCOUNT'] = getattr(settings, 'GOOGLE_ANALYTICS_ACCOUNT', '')
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.