1. portix
  2. dwb
  3. Pull requests

Pull requests

#14 Open
Repository
ram-z
Branch
master
Repository
portix
Branch
master

formfiller: escape ' " ` \ properly

Bitbucket cannot automatically merge this request.

The commits that make up this pull request have been removed.

Bitbucket cannot automatically merge this request due to conflicts.

Review the conflicts on the Overview tab. You can then either decline the request or merge it manually on your local system using the following commands:

git checkout master
git remote add ram-z/dwb https://bitbucket.org/ram-z/dwb.git
git fetch ram-z/dwb
git merge --no-ff -m 'Merged in ram-z/dwb (pull request #14)' remotes/ram-z/dwb/master
Author
  1. ram-z
Reviewers
Description

formfiller didn't escape those chars properly. This patch fixes that. The updated version uses heredocs to also support `

Steps to reproduce: 1. go to any login form

2a. enter login: foo & passwd: foo"bar 3a. save form: efg nothing happens (check with gpg2 -d .config/dwb/forms)

2b. enter login: foo & passwd: foob\ar 3b. save form: efg forms now contains: "value":"foob\ar" 4b. load form: eff returns: "Error in line 305: JSON Parse error: Invalid escape character a"

Comments (0)