1. LA KLIPPERS Avatar LA KLIPPERS
  2. pyKLIP
  3. pyklip
  4. Issues

Missing keyword "numthreads" when calling "generate_noise_maps"

Issue #34 resolved
Jonas Kemmer created an issue

Hello,

I noticed a bug in "klip_parallelized_lite" and "klip_parallelized". In both functions, when "generate_noise_maps" is called, the number of threads is not passed. This causes the function to take the default of None and thus using all cores.

Best regards, Jonas

Comments (3)

  2. Jason Wang

    Hi Jonas, thanks for noticing this! I just fixed this bug in commit a8693f7. Let me know if you have any issues.

    Also, if you are interested in commiting, you are welcome to make your own bug fixes and contributing them to the repository. All you need to do is fork the repository, make changes, and submit a pull request (proper way to do it). Or I can give you some write access to pyklip.

    -Jason

  3. Jonas Kemmer reporter

    Hello Jason,

    thanks for your quick response and also your offer. Indeed, I should fork the repository and contribute myself.

    Best regards, Jonas

  4. Log in to comment
Assignee
Type
bug
Priority
major
Status
resolved
Votes
0
Watchers
1
Jira: the preferred issue tracker for Bitbucket. Join the team!