Lenard Lindstrom avatar Lenard Lindstrom committed b6e948d

Make the Surface.get_at_mapped method value consistent with Surface.map_rgb

Surface.map_rgb returns a signed Python int, which can be negative for some
pixel values. Surface.get_at_mapped returned strictly positive pixel values.
This lead to a unit test failure in pixelcopy_test.py for an x86_64 Pygame
build, though the test should have passed. Since get_at_mapped was added
for testing purposed, its return value should be consistent with map_rgb,
which predates get_at_mapped.

Comments (0)

Files changed (1)

     SDL_PixelFormat *format = surf->format;
     Uint8 *pixels = (Uint8 *) surf->pixels;
     int x, y;
-    Uint32 color;
+    Sint32 color;
     Uint8 *pix;
 
     if (!PyArg_ParseTuple (args, "(ii)", &x, &y))
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.