setup.py exits with zero exit code when failing

illume avatarillume created an issue

Sridhar Ratnakumar, 2009-07-24 17:50:35 -0700

> python setup.py install --root=i1

WARNING, No "Setup" File Exists, Running "config.py"
Using UNIX configuration...

Hunting dependencies...
sh: sdl-config: not found
WARNING: "sdl-config" failed!
sh: smpeg-config: not found
WARNING: "smpeg-config" failed!
Unable to run "sdl-config". Please make sure a development version of SDL is installed.
> echo $?
0
> 

***

I am automatically building the packages in PyPI for some reason; and relying on the exit code of setup.py to see if a build failed or not. Your package (pygame) is the only aberration I've come across. 

Try using "sys.exit(1)" or "raise SystemExit, 'Unable to run ....'"

Comments (8)

  1. illume

    The config system should probably exit with an error code if it can not find the required dependencies. I'm not sure what affect this would have on various build systems, since it is quite a change. However, I think it probably should be a hard fail if the dependencies can not be found.

    I think this would make it easier on people to notice that they have forgotten to install a dependency.

  2. Log in to comment
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.