Issue #68 resolved

pygame won't compile against linux-headers-2.6.38 due to V4L1 removal

illume
created an issue

== , 2011-03-22 03:43:39 -0700

{{{ pygame won't compile against linux-headers-2.6.38 due to V4L1 removal. This is true for version 1.9.1 and SVN as of today 22 marc 2011

x86_64-pc-linux-gnu-gcc -pthread -march=btver1 -mcx16 -msahf -mpopcnt --param l1-cache-size=32 --param l1-cache-line-size=64 --param l2-cache-size=512 -O2 -pipe -mno-3dnow -DG_DISABLE_ASSERT -DNO_DEBUG -DNDEBUG -fomit-frame-pointer -frename-registers -fpredictive-commoning -fweb -ftree-vectorize -fgcse-sm -fgcse-las -fgcse-after-reload -minline-stringops-dynamically -findirect-inlining -fPIC -D_REENTRANT -I/usr/X11R6/include -I/usr/include/SDL -I/usr/include/python2.6 -c src/_camera.c -o build-2.6/temp.linux-x86_64-2.6/src/_camera.o In file included from src/_camera.c:36:0: src/camera.h:41:32: fatal error: linux/videodev.h: Nie ma takiego pliku ani katalogu compilation terminated. distcc[10903] ERROR: compile src/_camera.c on localhost failed error: command 'x86_64-pc-linux-gnu-gcc' failed with exit status 1 }}}


== Martijn Schmidt, 2011-03-24 09:48:01 -0700

{{{ Created attachment 43 Proposed patch which rips v4l version 1 support out of pygame.

This is my first patch ever, so please bear with me. It removes all references to v4l version 1 from pygame which means you could also remove "src/camera_v4l.c" from the package.

A cleaner way to pull it off might be using a similar trick to the python3 check in setup.py, but I am not proficient enough in Python to do this. Search for "#python 3.x: remove modules not yet ported" in setup.py to see what I'm talking about. On the other hand, this might not work due to the fact that camera_v4l.c is not its own extension but rather a part of _camera. }}}


Attachments: [[http://www.pygame.org/old_bug_attachments/43/pygame-v4l.patch| pygame-v4l.patch]]

== Martijn Schmidt, 2011-03-24 10:02:13 -0700

{{{ (In reply to comment #1)

A cleaner way to pull it off might be using a similar trick to the python3 check in setup.py, but I am not proficient enough in Python to do this. Search for "#python 3.x: remove modules not yet ported" in setup.py to see what I'm talking about. On the other hand, this might not work due to the fact that camera_v4l.c is not its own extension but rather a part of _camera.

Actually, since kernel 2.6.38 and up have completely removed v4l version 1 support it might be time to get rid of the code anyway? }}}


== Nirav Patel, 2011-04-23 11:29:07 -0700

{{{ (In reply to comment #2)

(In reply to comment #1)

A cleaner way to pull it off might be using a similar trick to the python3 check in setup.py, but I am not proficient enough in Python to do this. Search for "#python 3.x: remove modules not yet ported" in setup.py to see what I'm talking about. On the other hand, this might not work due to the fact that camera_v4l.c is not its own extension but rather a part of _camera.

Actually, since kernel 2.6.38 and up have completely removed v4l version 1 support it might be time to get rid of the code anyway?

Yep, it was just placeholder code anyway. The v4l support was never finished, and is less useful now than ever before. }}}


== Nirav Patel, 2011-04-23 11:39:58 -0700

{{{ Committed a slightly modified patch:

Sending Setup_Unix.in Sending src/_camera.c Sending src/camera.h Deleting src/camera_v4l.c Transmitting file data ... Committed revision 3077. }}}


Comments (1)

  1. Log in to comment