exits with zero exit code when failing

Issue #35 closed
René Dudfield created an issue

== Sridhar Ratnakumar, 2009-07-24 17:50:35 -0700


python install --root=i1

WARNING, No "Setup" File Exists, Running "" Using UNIX configuration...

Hunting dependencies... sh: sdl-config: not found WARNING: "sdl-config" failed! sh: smpeg-config: not found WARNING: "smpeg-config" failed! Unable to run "sdl-config". Please make sure a development version of SDL is installed.

echo $? 0

I am automatically building the packages in PyPI for some reason; and relying on the exit code of to see if a build failed or not. Your package (pygame) is the only aberration I've come across.

Try using "sys.exit(1)" or "raise SystemExit, 'Unable to run ....'" }}}

Comments (10)

  1. René Dudfield reporter

    The config system should probably exit with an error code if it can not find the required dependencies. I'm not sure what affect this would have on various build systems, since it is quite a change. However, I think it probably should be a hard fail if the dependencies can not be found.

    I think this would make it easier on people to notice that they have forgotten to install a dependency.

  2. Thomas Kluyver

    Exit with status 1 if sdl-config missing

    sys.exit() with a message == print the message and exit with code 1.

    Raising SystemExit also works, but it only gives code 1 if it has a message.

    Closes #35

    → <<cset b5aaa063a03e>>

  3. Log in to comment