1. pygame
  2. pygame
  3. pygame
  4. Pull requests

Pull requests

#29 Declined
Repository
pygame - small mac fix
Branch
default
Repository
pygame
Branch
default

Mac SDL library fix

Author
  1. Jakob Lautrup Nysom
Reviewers
Description

Added a change so that mac either uses local SDL libraries, or ones from a framework file. This should remove PyObjC warning about it not knowing which SDL lib to use, that appeared when some dependencies were found in /usr/local/lib and some in /Library/Frameworks/SDL.framework (due to local libs being checked before frameworks). Now it first checks for local libs, but falls back on only using the framework if any of these dependencies fail. ( I apologize if the code might be a little bit messy ).

Comments (2)

  1. René Dudfield

    Thanks!

    I'm a bit frightened of this pull request, because I have to do a lot of testing to see if this works. Or if this is how we want it to work.

    However, I need to do this testing.

    We should consider these systems, to see if it has any effect on them.

    • homebrew
    • macports
    • fink
  2. René Dudfield

    I'm not sure it's needed any more, and it's been open for a long time without activity. So closing it. If anyone still thinks it's a problem and wants to finish it off, feel free to open.