Pull requests

#28 Declined
Repository
williambr williambr
Branch
record
Repository
pypa pypa
Branch
default

Do not override _bytecode_filenames

Author
  1. William Grzybowski
Reviewers
Description

The overridden version cannot handle Python 3.x while distutils verion can handle it just fine.

To reproduce the issue try setup.py install --record recordfile, using python 3.x.

Comments (2)

  1. Jason R. Coombs

    Can you file a ticket reporting what the failure is and what you expect instead? I'd be interested to know if it's failing because the bytecode files are stored in a different location. I'm reluctant to simply remove code without first understanding why the code was there. Perhaps this code is no longer necessary, but to be sure, it's necessary to understand why it was added in the first place.

  2. William Grzybowski author

    The problem is describe in the commit log. --record will not work for python 3.x, it will append .pyc and .pyo, while it is not valid. _bytecode_filenames from python base distutils will handle it more gracefully.