#21 Merged at 3b28aef

fixes a bug where a Basic auth digest header can get encoded with newlines inside

Author

Jonathan Dye

Reviewers

Description

i ran into this bug because i was using a localshop server, which uses long tokens for the username and password. the output from the base64 encoding module will write newlines according to the spec (76 characters i think), and they were getting sent as part of the basic auth header thusly:

============== 8< ============

Authorization: Basic MDVmZDMyYgkyNgg0NDczY2FiMDAwZjBhY2I5NGRkYzg2NDZlYmMyNmNhNGExNDA5OGI5YWQ2MzFl M2RkMmMxYjE=

============== 8< ============

Comments (6)

Jonathan Dye author

(wrapping defeats the example as usual, the newline is here ...2MzFl\nM2RkMmMxYjE=)
- 2013-10-31T09:43:51+00:00
Jonathan Dye author

something wrong with this pull request?
- 2013-11-11T17:48:12+00:00
Jonathan Dye author

Cheryl Fillekes thanks =)
- 2013-11-13T16:16:42+00:00
Cheryl Fillekes

Hey this is great. It would be great if this fix were incorporated in an official release of setuptools...
- 2013-11-13T16:17:52+00:00
Jonathan Dye author

ty sir
- 2013-11-14T20:20:05+00:00
Cheryl Fillekes

yay!
- 2013-11-14T23:55:27+00:00

setuptools

Pull requests

fixes a bug where a Basic auth digest header can get encoded with newlines inside

Comments (6)

Help